-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat!: Upgrade AWS provider and min required Terraform version to 6.0 and 1.10 respectively #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is included in version 5.0.0 🎉 |
I think Outputs should have been updated as well:
output "s3_bucket_region" {
description = "The AWS region this bucket resides in."
- value = try(aws_s3_bucket.this[0].region, "")
+ value = try(aws_s3_bucket.this[0].bucket_region, "")
} |
@nightspotlight The output has been fixed in #343 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
.name -> .region
examples/complete-legacy
region
in all resourcesCloses #333
Breaking Changes
It is fully compatible with v6, but will cause issues with anything less. Justifies a major version jump of the module.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request